Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Added missing templates: Jail, Bed and Colorfy #174

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Feat: Added missing templates: Jail, Bed and Colorfy #174

merged 2 commits into from
Oct 31, 2023

Conversation

carefreeav09
Copy link
Contributor

Description

Added missing templates: Jail, Bed and Colofy.

Motivation and Context

Some of the templates in the legacy build were missing.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

twlite
twlite requested changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@twlite twlite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution, I have left a review below.

src/assets/TemplateFactory.ts Show resolved Hide resolved
twlite
twlite approved these changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@twlite twlite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@twlite twlite merged commit ce8800b into neplextech:main Oct 31, 2023
@carefreeav09
Copy link
Contributor Author

Updated as suggested!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twlite twlite twlite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carefreeav09 @twlite