Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: stop relying on CMAKE_BUILD_TYPE to determine the build type #22051

Merged
merged 1 commit into from
Feb 2, 2023

Commits on Feb 2, 2023

  1. build: stop relying on CMAKE_BUILD_TYPE to determine the build type

    Any logic involving CMAKE_BUILD_TYPE is automatically broken as it won't
    work with multi-config generators. The only exception is if we
    explicitly check whether the current generator is single-config as well.
    Instead, use generator expressions or cmake variables that allows to set
    options for certain build types only such as
    INTERPROCEDURAL_OPTIMIZATION_<CONFIG>.
    
    Opt to generate all headers with optimization level O2 with no debug
    information for all build types as that is the simplest way to make it
    behave the same for all generators.
    dundargoc committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    71a5160 View commit details
    Browse the repository at this point in the history