fix(treesitter): validate language name #22005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk
approved these changes
Jan 26, 2023
clason
force-pushed
the
sanitize-lang
branch
2 times, most recently
from
0e00ece
to
4c559e2
Compare
Problem: Some injections (like markdown) allow specifying arbitrary language names for code blocks, which may be lead to errors when looking for a corresponding parser in runtime path. Solution: Validate that the language name only contains alphanumeric characters and `_` (e.g., for `c_sharp`) and error otherwise.
|
Standard meeting rules: approved by silent acclamation. |
|
Successfully created backport PR #22074 for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some injections (like markdown) allow specifying arbitrary language names for code blocks, which may lead to errors when looking for a corresponding parser with the same name in runtimepath.
Solution
Validate that the language name only contains alphanumeric characters and
_(e.g., forc_sharp) and error otherwise.Alternative approach
lang:gsub('%W',''), but that would also strip_, which is used for a number of language names in nvim-treesitter.Closes #21485
Supersedes #21943
@bfredl @stsewd