Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(decoration): do not reset must_redraw after calling providers #21459

Merged
merged 1 commit into from
Dec 21, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(decoration): do not restart win_update() after calling providers
This is likely no longer needed after #20665
  • Loading branch information
zeertzjq committed Dec 17, 2022
commit 551ebf422f031eec4667a02e95b15ab3812f6ade
10 changes: 0 additions & 10 deletions src/nvim/drawscreen.c
Original file line number Diff line number Diff line change
Expand Up @@ -956,9 +956,6 @@ static void draw_sep_connectors_win(win_T *wp)
/// bot: from bot_start to last row (when scrolled up)
static void win_update(win_T *wp, DecorProviders *providers)
{
bool called_decor_providers = false;
win_update_start:
;
int top_end = 0; // Below last row of the top area that needs
// updating. 0 when no top area updating.
int mid_start = 999; // first row of the mid area that needs
Expand Down Expand Up @@ -1028,13 +1025,6 @@ static void win_update(win_T *wp, DecorProviders *providers)

DecorProviders line_providers;
decor_providers_invoke_win(wp, providers, &line_providers, &provider_err);
if (must_redraw != 0) {
must_redraw = 0;
if (!called_decor_providers) {
called_decor_providers = true;
goto win_update_start;
}
}

redraw_win_signcol(wp);

Expand Down