BUGFIX: 3557 placeholder plugin with autoparagraph false #3558
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #3557
as the placeholder plugin was a bit hacky and broke in a regression from #3532
Because
editor.getData
now returned the new internal<neos-inline-wrapper>
tags. The preprocessing to strip them is now applied earlier, so other calls toeditor.getData
now get the expected results.also a problem is resolved that no placeholder is shown, if one chooses
h1
tag whenautoparagraph false
is enabledadditionally it cleans up the codebase and uses the native ckeditor placeholder plugin instead of our hacky home-brewed solution.
before and after:
Bildschirmaufnahme.2023-07-03.um.10.13.27.mov
Bildschirmaufnahme.2023-07-03.um.10.15.44.mov
Bildschirmaufnahme.2023-07-03.um.10.14.14.mov
What I did
How I did it
How to verify it