✨ Config option to keep the websurfx server connection alive for a certain period for subsequent requests
#568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neon-mmd
changed the title
websurfx server connection alive for a certain period for subsequent requests
neon-mmd
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Provided a new config option to keep client connections between the server and the client alive for a certain period of time specified via the config. The default value for this option is chosen to be 120 seconds (2 minutes).
Why is this change important?
Helps reduce the latency between the request and response time for the search results. As a reduction of overhead normally required to reconnect.
How to test this PR locally?
It can be tested by installing and running Websurfx as mentioned in the
docsand on thereadmeand by launching the browser and thoroughly testing. By verifying the server connections are still established by checking network sockets via network analysis tool.Related issues
Closes #558