🎨 Change http header word/sentence casing
#555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently all HTTP request headers are in snake case and upper case. The adopted standard is kebab case and title case. Here you will find more details: https://en.wikipedia.org/wiki/List_of_HTTP_header_fields#Standard_request_fields
http header word/sentence casing
neon-mmd
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The PR fixes the casing of the HTTP request headers sent to the search engines.
Why is this change important?
Currently all HTTP request headers are in snake case and upper case.
The adopted standard is kebab case and title case.
Here you will find more details 👉 Standard request fields
Although using title case is optional, the usage of snake case for phrases is a must.
How to test this PR locally?
You can temporarily add
println!("{:#?}, header_map);after each initialization of the HeaderMap.Then just execute
cargo runand make a search.