✨ Config option to timeout requests for fetching search results from the upstream search engines #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meout requests for fetching the search results from the upstream search engines.
neon-mmd
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Provides a new HTTP connection setting to the
reqwest::ClientBuilderto timeout requests for fetching the search results from the upstream search engines.Why is this change important?
The reason for including these changes is to timeout connections after a certain user specified period of time. This prevents the connections from hanging on for the response for a long time to return from the upstream search engines which can cause a long a delay for results to show up on the search page. So by working on these change it improves the user experience by not hanging on too long for search results to appear from each upstream engine.
Related issues
Closes #524