Self-hosted cargo-cp-artifact
#971
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Core functionality implemented in crates/cargo-cp-artifact as a regular crate - crates/cargo-cp-artifact also has a bin so it can be used to build the self-hosted JS package - pkgs/cargo-cp-artifact has a Neon implementation that depends on crates/cargo-cp-artifact - pkgs/cargo-cp-artifact/package.json uses `cargo run -p cargo-cp-artifact` to build itself from the monorepo
dherman
force-pushed
the
self-hosted-cargo-cp-artifact
branch
from
9a59f28
to
436c872
Compare
- Wrap HashMap in a custom CopyMap type - Move push_artifact into CopyMap::insert - Move some of CargoCommand::exec into CopyMap::copy - Move copy_artifact into Artifact::copy
dherman
commented
Mar 1, 2023
pkgs/cargo-cp-artifact/package.json
Outdated
| ], | ||
| "bin": { | ||
| "cargo-cp-artifact": "bin/cargo-cp-artifact.js" | ||
| }, | ||
| "scripts": { | ||
| "test": "mocha test" | ||
| "build": "cargo run -p cargo-cp-artifact -- -ac cargo-cp-artifact-adapter index.node -- cargo build --message-format=json-render-diagnostics", |
There was a problem hiding this comment.
This works in tree, but won't work when installed from npm. The next step is now to implement pre-builds.
dherman
force-pushed
the
self-hosted-cargo-cp-artifact
branch
from
2b399a4
to
1abff5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #966. Implementation notes:
crates/cargo-cp-artifactas a regular cratecrates/cargo-cp-artifactalso has a bin so it can be used to build the self-hosted JS packagepkgs/cargo-cp-artifacthas a Neon implementation that depends oncrates/cargo-cp-artifactpkgs/cargo-cp-artifact/package.jsonusescargo run -p cargo-cp-artifactto build itself from the monorepo