Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cargo-cp-artifact): use copyArtifact from @neon-rs/artifact #1046

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dherman
Copy link
Collaborator

@dherman dherman commented May 19, 2024

Closes #1045.

@dherman dherman requested a review from kjvalencik May 19, 2024 18:01
@kjvalencik
Copy link
Member

cargo-cp-artifact currently has zero dependencies. I'm not sure if adding one for ~20 LoC is worth it.

@dherman
Copy link
Collaborator Author

dherman commented May 20, 2024

cargo-cp-artifact currently has zero dependencies. I'm not sure if adding one for ~20 LoC is worth it.

It's an internal dependency, though: we maintain all the code. It's just that we use it in two different CLI tools, so it avoids us having to maintain it in two places.

@kjvalencik
Copy link
Member

Given that we are likely to stop maintaining cargo-cp-artifact, my preference is not to couple the two and potentially make the neon CLI more difficult to maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo-cp-artifact: refactor to use @neon-rs/artifact
2 participants