Skip to content

Commit

Permalink
container.Base: removeAt() without destroying the component instance …
Browse files Browse the repository at this point in the history
…should remove layout related css rules #5438
  • Loading branch information
tobiu committed Jun 22, 2024
1 parent 19129e9 commit b7bd601
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion examples/component/helix/MainContainer.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ class MainContainer extends Viewport {
ntype : 'panel',
layout : {ntype: 'vbox', align: 'stretch'},
reference: 'controls-panel',
style : {backgroundColor: '#2b2b2b', flex: 'none'},
style : {backgroundColor: '#2b2b2b'},
width : 250,

containerConfig: {
Expand Down
1 change: 1 addition & 0 deletions src/container/Base.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -678,6 +678,7 @@ class Base extends Component {
item.destroy(true, silent);
return null
} else {
me.layout?.removeChildAttributes(item);
item.mounted = false;
return item
}
Expand Down
2 changes: 1 addition & 1 deletion src/layout/Flexbox.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ class Flexbox extends Base {
}

/**
* Removes all CSS rules from an container item this layout is bound to.
* Removes all CSS rules from a container item this layout is bound to.
* Gets called when switching to a different layout.
* @param {Neo.component.Base} item
* @protected
Expand Down

0 comments on commit b7bd601

Please sign in to comment.