Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python Source Code Optimization #19

Closed
wants to merge 1 commit into from
Closed

Python Source Code Optimization #19

wants to merge 1 commit into from

Conversation

AxylumRust
Copy link

No description provided.

Romanov-R
Romanov-R reviewed Nov 14, 2023
View reviewed changes
utils/bypass.py
status = ['PASSED', status_code] if status_code in block_code else ['BYPASSED', status_code]
else:
status = ['PASSED', status_code] if status_code not in block_code else ['FALSED', status_code]
status = ['PASSED', status_code] if status_code not in block_code else ['FALSED', status_code]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BYPASSED losed

Romanov-R
Romanov-R reviewed Nov 14, 2023
View reviewed changes
Copy link
Contributor

@Romanov-R Romanov-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but It looks like code formatting, not code optimization
The commit contains errors

@AxylumRust
Copy link
Author

Hello,
There is some code formatting and also some optimization.
Could you please tell me where the error is?

@Romanov-R
Copy link
Contributor

Hello, There is some code formatting and also some optimization. Could you please tell me where the error is?

I don't find any optimization, could you provide an example?

Error example:
#19 (review)

@Romanov-R Romanov-R closed this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Romanov-R Romanov-R Romanov-R left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AxylumRust @Romanov-R