Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct module name and repo_name #564

Merged
merged 1 commit into from
May 25, 2024
Merged

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented May 25, 2024

The module name doesn't need to be aligned with the WORKSPACE name. When you follow the documentation and see module names in the BCR.
The name is the name of the project and the repo_name is the WORKSPACE name.
This provide this normalisation

@mmorel-35
Copy link
Contributor Author

@Vertexwahn,

WDYT ?

@mmorel-35 mmorel-35 marked this pull request as ready for review May 25, 2024 21:14
@Vertexwahn Vertexwahn merged commit 42d8155 into nelhage:master May 25, 2024
2 checks passed
@Vertexwahn
Copy link
Collaborator

@mmorel-35 Thanks for your contribution!

@mmorel-35 mmorel-35 deleted the patch-1 branch May 25, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants