Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable PR-free auto update, since branch protection settings prevent it. #280

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

cpsauer
Copy link
Collaborator

@cpsauer cpsauer commented Nov 10, 2022

No description provided.

@cpsauer cpsauer merged commit 4dd29ef into master Nov 10, 2022
@cpsauer cpsauer deleted the pr-automerge branch November 10, 2022 07:27
@cpsauer
Copy link
Collaborator Author

cpsauer commented Nov 10, 2022

@nelhage, auto-updates are all set up and merging away as tests pass. Wahoo!

One heads up: I had to disable the silent auto-merge feature (with this PR) because of your branch protection settings. If you let Renovate bypass them (and like, it won't mess up or otherwise merge untested commits, since it's a bot), then we can reduce the non-actionable notifications on green auto-updates.

Background: Normally, I configure Renovate to make only a branch--and not a PR--for updates it's going to attempt to auto merge. This saves everyone the non-actionable notifications and emails for updates that go through cleanly on their own. However, current branch protection settings seem to prevent Renovate from pushing a non-PR merge, even when the tip of the branch that's being merged has passed all checks. I bet if you configured the branch protection to not stop Renovate, we could re-enable the silent setting and save everyone some noise. Note that regardless, Renovate will only merge branches that are up to date with master and have passed all checks, and will create a PR to notify us if an update fails tests and requires manual intervention.

@cpsauer
Copy link
Collaborator Author

cpsauer commented Nov 10, 2022

BTW, all pull requests resolved :)

@nelhage
Copy link
Owner

nelhage commented Nov 12, 2022

I'm inclined to keep updates going through PRs for visibility and so that there's only one point responsible for enforcing branch policies -- github itself -- but maybe I'll change my mind if it's too noisy :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants