Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw an error if the steps has a invalid uses directive #500

Merged
merged 2 commits into from
Jan 23, 2021
Merged

Throw an error if the steps has a invalid uses directive #500

merged 2 commits into from
Jan 23, 2021

Conversation

lufia
Copy link
Contributor

@lufia lufia commented Jan 22, 2021

This closes #402, closes #487

@lufia lufia requested a review from cplee as a code owner January 22, 2021 08:54
cplee
cplee requested changes Jan 22, 2021
View reviewed changes
Copy link
Contributor

@cplee cplee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Can you add test cases for the valid scenario too? For example to confirm that uses with or without path are created successfully

@lufia
Copy link
Contributor Author

lufia commented Jan 23, 2021

@cplee I did it.

@cplee cplee merged commit 2d1a946 into nektos:master Jan 23, 2021
@lufia lufia deleted the fix-panics branch January 23, 2021 16:44
@catthehacker catthehacker mentioned this pull request Jan 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cplee cplee cplee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

act unhandled panic index out of range error
2 participants
@lufia @cplee