-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change handling of ExtraPath #406
Conversation
To make the handling of ExtraPath portable append it to the front of the PATH when it exists, instead of always changing the script.
@cplee I slept on your suggestion and came up with a different solution of adding ExtraPath to the PATH environment variable. Note: this is my first experience using Go so please don't laugh, but let me know your thoughts :) When I run
But what I've been doing is just Finally, I tried to run
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks, what do I need to do so |
In PR nektos#406 I used PathSeparator and I should have used PathListSeparator.
In PR nektos#406 I used PathSeparator and I should have used PathListSeparator. See: https://golang.org/pkg/os/#pkg-constants
In PR #406 I used PathSeparator and I should have used PathListSeparator. See: https://golang.org/pkg/os/#pkg-constants
To make the handling of ExtraPath portable append it to the front of the
PATH when it exists, instead of always changing the script.