Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: outputs espace #404

Merged
merged 4 commits into from
Nov 2, 2020
Merged

fix: outputs espace #404

merged 4 commits into from
Nov 2, 2020

Conversation

theowenyoung
Copy link
Contributor

fix #403

Hi, by the issue, I suppose that we should unescape the command string, I made a pr, please review it if you have time. Thanks!

@theowenyoung
Copy link
Contributor Author

Hi, @cplee , sorry to bother you, but can you review this if you have time? Thanks a lot

@cplee
Copy link
Contributor

cplee commented Nov 2, 2020

@theowenyoung - change looks good, and I appreciate the tests!

What do you think about defining a list of escape strings and compiling/matching the list? Seems like an improvement over:

var commandPatternEscapeChar2 *regexp.Regexp
var commandPatternEscapeChar3 *regexp.Regexp
var commandPatternEscapeChar4 *regexp.Regexp
var commandPatternEscapeChar5 *regexp.Regexp```

@theowenyoung
Copy link
Contributor Author

@cplee , Thanks, I'll try to change the code, but I'm a jser, not good at golang, I'll see what I can do, Thanks

@theowenyoung
Copy link
Contributor Author

@cplee Hi, I have edited the unescape function, use map list instead of multiple vars, and use strings.replace instead of regex, please review it if you have time, Thanks!

Copy link
Contributor

@cplee cplee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cplee cplee merged commit 92067eb into nektos:master Nov 2, 2020
@theowenyoung
Copy link
Contributor Author

@cplee Thanks for the quick review, hope a release version soon.

@theowenyoung
Copy link
Contributor Author

Hi, @cplee , May I known what time of the next release version? A project of mine rely act and I need this feature. Thanks!

@cplee
Copy link
Contributor

cplee commented Nov 8, 2020

@theowenyoung - just published v0.2.17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

step set output string should be unescaped
2 participants