Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Add] More logging for default push action #383

Merged
merged 1 commit into from
Oct 9, 2020
Merged

[Add] More logging for default push action #383

merged 1 commit into from
Oct 9, 2020

Conversation

TechIsCool
Copy link
Contributor

When we originally downloaded this tool and ran it. It appeared to do nothing. What actually happened was we had no push events in our repo. We turned up logging and didn't get any more helpful information. This adds enough to be helpful.

Adds more Logs for #32

@TechIsCool TechIsCool requested a review from cplee as a code owner October 7, 2020 01:19
@TechIsCool
Copy link
Contributor Author

TechIsCool commented Oct 7, 2020 •
edited
Loading

Since the unit test TestRunEvent/issue-228 is failing on another PR as well at the same point I will assume that its accurate but not my code.
cc #382

@cplee cplee merged commit 569ebac into nektos:master Oct 9, 2020
@lshamis lshamis mentioned this pull request Oct 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cplee cplee cplee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TechIsCool @cplee