Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make node tool non volatile #2372

Merged
merged 4 commits into from
Jul 10, 2024
Merged

fix: make node tool non volatile #2372

merged 4 commits into from
Jul 10, 2024

Conversation

ChristopherHX
Copy link
Contributor

Currently downgrading node via setup-node can break later actions

Currently downgrading node via setup-node can break later actions
Copy link
Contributor

github-actions bot commented Jun 21, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 9 0 0.04s
✅ REPOSITORY gitleaks yes no 2.28s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 9.46s
✅ REPOSITORY secretlint yes no 1.09s
✅ REPOSITORY trivy-sbom yes no 0.47s
✅ REPOSITORY trufflehog yes no 3.9s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@deltreey
Copy link

Love it! Thank you for doing this!

@ChristopherHX ChristopherHX marked this pull request as ready for review June 21, 2024 17:06
@ChristopherHX ChristopherHX requested a review from a team as a code owner June 21, 2024 17:06
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 97.91667% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.59%. Comparing base (5a80a04) to head (395a0da).
Report is 88 commits behind head on master.

Files Patch % Lines
pkg/runner/expression.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2372       +/-   ##
===========================================
+ Coverage   61.56%   76.59%   +15.03%     
===========================================
  Files          53       61        +8     
  Lines        9002     7893     -1109     
===========================================
+ Hits         5542     6046      +504     
+ Misses       3020     1292     -1728     
- Partials      440      555      +115     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot merged commit 6de25a5 into master Jul 10, 2024
11 checks passed
@mergify mergify bot deleted the non-volatile-node-tool branch July 10, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants