Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft: LXC support for self-hosted runners #1682

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Draft: LXC support for self-hosted runners #1682

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c7f0532
add stopHostEnvironment to tear down the LXC container
earl-warren Mar 12, 2023
9c95665
shell script to start the LXC container
earl-warren Mar 12, 2023
3ee8456
create and destroy a LXC container
earl-warren Mar 12, 2023
fbad698
run commands with lxc-attach
earl-warren Mar 13, 2023
643a462
expose additional devices for docker & libvirt to work
earl-warren Mar 14, 2023
2ccb312
install node 16 & git for checkout to work
earl-warren Mar 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
add stopHostEnvironment to tear down the LXC container
  • Loading branch information
@earl-warren
earl-warren committed Mar 16, 2023
commit c7f05329f734889209520b668b289dba22002d59
16 changes: 15 additions & 1 deletion pkg/runner/run_context.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,14 @@ func (rc *RunContext) GetBindsAndMounts() ([]string, map[string]string) {
return binds, mounts
}

func (rc *RunContext) stopHostEnvironment() common.Executor {
return func(ctx context.Context) error {
logger := common.Logger(ctx)
logger.Debugf("stopHostEnvironment")
return nil
}
}

func (rc *RunContext) startHostEnvironment() common.Executor {
return func(ctx context.Context) error {
logger := common.Logger(ctx)
Expand Down Expand Up @@ -397,7 +405,13 @@ func (rc *RunContext) IsHostEnv(ctx context.Context) bool {
}

func (rc *RunContext) stopContainer() common.Executor {
return rc.stopJobContainer()
return func(ctx context.Context) error {
image := rc.platformImage(ctx)
if strings.EqualFold(image, "-self-hosted") {
return rc.stopHostEnvironment()(ctx)
}
return rc.stopJobContainer()(ctx)
}
}

func (rc *RunContext) closeContainer() common.Executor {
Expand Down