Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow define extra fields for sign up #36

Merged
merged 2 commits into from
Dec 27, 2023

Conversation

Plus17
Copy link
Contributor

@Plus17 Plus17 commented Dec 4, 2023

First of all, thank you very much for the work, I love this gem.

I would love to have the option to add a tos field to the sign up.

So this PR adds the extra_fields option in the sign_up config to be used by the method sign_up_params in the TokensController. I hope it is useful and can be included.

@nejdetkadir nejdetkadir linked an issue Dec 4, 2023 that may be closed by this pull request
@melchua
Copy link

melchua commented Dec 27, 2023

This would be super useful. Hope this can be reviewed/merged soon. I'm testing out the PR on my project.

@nejdetkadir nejdetkadir self-requested a review December 27, 2023 09:55
@nejdetkadir nejdetkadir merged commit f220683 into nejdetkadir:main Dec 27, 2023
@AzhirAhmadi
Copy link

Hi @nejdetkadir thanks for this great gem, Configuring the Devise for API was always a pain.

could you please update the RubyGems page's latest version too?
The latest version is 1.3 which does not contain this change, in the read me file you added eaxtra_fields to devise-api configs and it will raise an error since the gem from RubyGems (gem with latest version 1.3) does not have this change. I have to set the gem to the git repo main branch to fix this error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow configuring additional fields for API registration
4 participants