Fix undefined variable error in controller helper #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within
lib/devise/api/controllers/helpers.rb
theresource_class
is being passed intoDevise::Api::Responses::ErrorResponse
on initialization.resource_class
is a method inherited from the devise controllers so unfortunately, if we useauthenticate_devise_api_token!
in any controller that doesn't inherit from one, the gem will throw for blank, expired and revoked tokens, rather than handling it cleanly and returning the proper error.I've added what I think is a clean fix for the issue, and some accompanying specs. I'm happy to make any tweaks if needed :)
This issue was initially raised here #24 (comment)