Bug fix - Hourly Rain unit of measurement incorrect #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hourly rain is actually hourly rainfall RATE, not total
Change unit of measurement for hourly rain
|
Nice catch! Can you please open an issue for this as well so I can link the PR to the issue? |
|
Done! |
|
@tankdeer Can you also update the readme so it has the correct units listed? Also is this just the hourly rain and not the other rain measurement totals? |
|
Answering my own question: it's just this measurement :) |
|
Oops. Yes, let me fix the readme too. Give me a few minutes - trying to cook dinner at the same time 😄 |
neilenns
requested changes
Jun 18, 2022
neilenns
approved these changes
Jun 18, 2022
|
Awesome, thanks |
|
Thanks for finding and fixing it! New release is published, including the HA add on. |
|
Happy to help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #80
Hope you don't find this too presumptuous of me. I've been playing with this the past few days since the add-on was created, and noticed a small bug.
hourlyRainis being reported as inches, when in fact it should be inches per hour. It is not a static measurement, but a measurement of the current rate of rainfall.This is confirmed in the documentation here, and also matches what the official add-on reports.