Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyenchant is a speed bump #1593

Closed
nedbat opened this issue Mar 21, 2023 · 1 comment
Closed

pyenchant is a speed bump #1593

nedbat opened this issue Mar 21, 2023 · 1 comment
Labels
bug Something isn't working build docs fixed

Comments

@nedbat
Copy link
Owner

nedbat commented Mar 21, 2023

When a new contributor tries to run tests for the first time, the docs environment can fail because sphinxcontrib-spelling needs a native OS "enchant" package installed.

Is it worth it to have sphinxcontrib-spelling in the mix? Can we only involve it when doing a spell check, which is a manual step?
@nedbat nedbat added bug Something isn't working build docs labels Mar 21, 2023
nedbat added a commit that referenced this issue Mar 21, 2023
@nedbat
build(docs): only load sphinxcontrib.spelling if we are spell-checking …
ef40735 
…#1593
@nedbat
Copy link
Owner Author

nedbat commented Mar 21, 2023

This is fixed in ef40735. The sphinxcontrib.spelling extension is only loaded when spell checking.

@nedbat nedbat closed this as completed Mar 21, 2023
@nedbat nedbat added the fixed label Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working build docs fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nedbat