This repository has been archived by the owner on Jul 11, 2019. It is now read-only.
Cnanjo 2018 03 29 branch #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctor and fix tests
Changed logger to slf4j. Removed IOUtils dependency because recent ANTLR version includes the functionality directly.
Update docs 2
Throw Exceptions on incorrect use of MetaModels
Fix effective occurrences with a differential path instead of RM Attr…
Fix BMM tests to use BMM metamodels only, plus some fixes
use term in parent archetype instead of term in archetype root
|
My apologies. The pull request was intended for the OpenEHR fork and not Nedap. I must have overlooked this when creating it in the first place. Closing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On line 167 of ArchetypeValidator, the setting of flattened archetypes in the result is skipped if either errors or warnings are present. yet, the correct behavior should probably be to only skip in case of errors and not in the case of warnings. Hence, modified if statement to check for the case of errors explicitly by changing the condition from messages.isEmpty() to result.passes().