This repository has been archived by the owner on Jul 11, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic rule evaluation. Evaluates:
Interprets everything as a list, so if you do
And the ModelReference/adl_path returns two values (very very possible in the RM!), it will do both the computation and the assertion twice. If one of the two checks fail, the assertion will have failed.
The individual check results remain, so if one succeeds and one fails, the assertion result will be:
It would be great to store all object references used in every computation, so in a UI you could show which exact fields make this assertion fail, and which are fine.
Assertion labels/tags are still odd: you can add them, and they do help, but there's no way to add to the terminology yet. I think there should be, so you can add error messages that make sense.