Skip to content
This repository has been archived by the owner on Jul 11, 2019. It is now read-only.

Performance fixes #31

Merged
merged 5 commits into from
Mar 17, 2017
Merged

Performance fixes #31

merged 5 commits into from
Mar 17, 2017

Conversation

pieterbos
Copy link
Member

@pieterbos pieterbos commented Mar 15, 2017

It's hard to write good code if this thing keeps returning the same object and that object is immutable. Just return more objects.

Will make parsing slightly more expensive, but shouldn't be a problem - this was mainly done before the ModelInfoLookup classes were written, which means it's performant as is.

Also other performance fixes.

@codecov-io
Copy link

codecov-io commented Mar 15, 2017

Codecov Report

Merging #31 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master      #31      +/-   ##
============================================
- Coverage     65.97%   65.94%   -0.03%     
+ Complexity     1893     1892       -1     
============================================
  Files           311      311              
  Lines          6686     6681       -5     
  Branches        817      814       -3     
============================================
- Hits           4411     4406       -5     
- Misses         1891     1892       +1     
+ Partials        384      383       -1
Impacted Files Coverage Δ Complexity Δ
.../com/nedap/archie/query/APathToXPathConverter.java 79.24% <100%> (ø) 16 <1> (+1)
.../main/java/com/nedap/archie/paths/PathSegment.java 93.33% <100%> (+0.47%) 23 <6> (ø)
.../modelconstraints/ReflectionConstraintImposer.java 100% <100%> (+8%) 6 <6> (ø)
...in/java/com/nedap/archie/query/RMQueryContext.java 72.58% <100%> (+0.44%) 11 <0> (ø)
.../main/java/com/nedap/archie/rminfo/RMTypeInfo.java 90.9% <0%> (-9.1%) 5% <0%> (-1%)
.../java/com/nedap/archie/rminfo/ModelInfoLookup.java 77.06% <0%> (-0.92%) 30% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87f5384...45de138. Read the comment docs.

@jpleppers
Copy link
Member

👍

@pieterbos pieterbos changed the title Make constraintimposer return new CAttribute objects for safety reasons Performance fixes Mar 17, 2017
@pieterbos pieterbos merged commit 1e13f71 into master Mar 17, 2017
@pieterbos pieterbos deleted the fix_constraintimposer branch March 17, 2017 13:04
pieterbos added a commit that referenced this pull request Aug 21, 2018
Add archetype editing functionality, fix some bugs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants