-
Notifications
You must be signed in to change notification settings - Fork 26
Conversation
…ng should be in code, needed for path lookup
…mmar to camelCase
Codecov Report@@ Coverage Diff @@
## master #27 +/- ##
============================================
+ Coverage 65.65% 65.86% +0.21%
- Complexity 1857 1882 +25
============================================
Files 309 309
Lines 6609 6644 +35
Branches 793 804 +11
============================================
+ Hits 4339 4376 +37
Misses 1895 1895
+ Partials 375 373 -2
Continue to review full report at Codecov.
|
src/main/antlr/adl_rules.g4
Outdated
| multiplying_expression mult_binop pow_expression | ||
multiplyingExpression | ||
: powExpression | ||
| multiplyingExpression mult_binop powExpression |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactor mult_binop to multBinop as well?
src/main/antlr/adl_rules.g4
Outdated
arithmetic_leaf: | ||
boolean_literal | ||
expressionLeaf: | ||
booleanLiteral | ||
| integer_value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
integerValue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this has been defined in another file and cannot be refactored at the moment
src/main/antlr/adl_rules.g4
Outdated
arithmetic_leaf: | ||
boolean_literal | ||
expressionLeaf: | ||
booleanLiteral | ||
| integer_value | ||
| real_value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
realValue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this has been defined in another file and cannot be refactored at the moment
Fix BMM tests to use BMM metamodels only, plus some fixes
Lots of fixes: