This repository has been archived by the owner on Jul 11, 2019. It is now read-only.
Add tests and some cleanup #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -198,7 +198,7 @@ public APathQuery(String query) { | |||
|
|
|||
| } | |||
|
|
|||
|
|
|||
| @Deprecated | |||
There was a problem hiding this comment.
You could add comments that instead RMQueryContext should be used.
|
👍 looks good |
Current coverage is 65.16% (diff: 84.61%)@@ master #22 diff @@
==========================================
Files 308 308
Lines 6501 6480 -21
Methods 0 0
Messages 0 0
Branches 980 978 -2
==========================================
+ Hits 4218 4223 +5
+ Misses 1916 1890 -26
Partials 367 367
|
pieterbos
added a commit
that referenced
this pull request
Mar 20, 2018
Throw Exceptions on incorrect use of MetaModels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for ModelInfoLookup and PathSegment
Small rewrites and fixes
Removed some obsolete code (although maybe it should be deprecated instead?)