This repository has been archived by the owner on Jul 11, 2019. It is now read-only.
Serializer updates #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed for template overlays
Adl parser will fail if there is no empty line between definition and terminology sections
Current coverage is 64.72% (diff: 52.94%)@@ master #20 diff @@
==========================================
Files 308 308
Lines 6489 6500 +11
Methods 0 0
Messages 0 0
Branches 977 979 +2
==========================================
+ Hits 4201 4207 +6
- Misses 1919 1922 +3
- Partials 369 371 +2
|
| ArchetypeTerm term = cobj.getArchetype().getTerm(cobj, cobj.getArchetype().getOriginalLanguage().getCodeString()); | ||
| String originalLanguage = ofNullable(cobj) | ||
| .flatMap(c -> ofNullable(c.getArchetype())) | ||
| .flatMap(a -> ofNullable(a.getOriginalLanguage())) |
There was a problem hiding this comment.
You can just use .map instead of flatmap and custom wrapping the result in an Optional:
String originalLanguage = ofNullable(cobj)
.map(CObject::getArchetype)
.map(Archetype::getOriginalLanguage)
.map(TerminologyCode::getCodeString)
.orElse(null);
Apart from that, it looks good 👍
pieterbos
added a commit
that referenced
this pull request
Mar 20, 2018
Fix operational template parsing 2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some issues that were encountered when converting adl designer to use archie parser/serializer/flattener.