Skip to content
This repository has been archived by the owner on Jul 11, 2019. It is now read-only.

Profiles #14

Merged
merged 11 commits into from
Jun 29, 2016
Merged

Profiles #14

merged 11 commits into from
Jun 29, 2016

Conversation

pieterbos
Copy link
Member

@pieterbos pieterbos commented Jun 29, 2016

Some backwards incompatible changes:

  • rename occurences to the correct occurrences
  • Locatable::setName(String) renamed to setNameAsString. setName(DvText) still is the same. Needed for JSON deserialization to work correctly
  • ModelInfoLookup now has two extra methods convertToConstraintObject and convertConstrainedPrimitiveToRMObject. This is used to convert between RM Objects and Archetype model objects. the CPrimitiveObject::isValidValue(Object) methods automatically do this, or alternatively you can pass a ModelInfoLookup instance as second parameter.
    This solves a hack where TerminologyCode inherits from CodePhrase, as well as some other problems. This no longer is the case and conversions happen where needed. This is documented under profiles in the openEHR specification. It may cause changes in object validation logic in applications using Archie.
  • AssertionResult now includes pathsThatMustExist, pathsThatMustNotExist and setPathValues even if the assertion result succeeded.
    This can be used in UIs: when checking rules first, you change the model. When checking again, you would not get the same results back. While the 'exists ...' means that this item should not be deletable, and you would not know. Now you do know, and can make the field/item/whatever non-deletable in interfaces for user input. This can change

backwards-compatible changes:

Refactor

  • setThisAsParent now works with collection (saves some code and mistakes)

Bugfixes:

  • bugfix in codephrase parsing
  • CTerminologyCode did not use correct fallback translation language in some cases
  • Date/DateTime/Time XML (de)serialization now works correctly

RM Model additions

  • Folder and GenericEntry added to RM

@pieterbos pieterbos merged commit acede81 into master Jun 29, 2016
@pieterbos pieterbos deleted the profiles branch June 29, 2016 11:39
pieterbos added a commit that referenced this pull request Mar 20, 2018
Fix canonical packages, use BMM in Archetype validation and flattening
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant