Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some updates and new security features #3

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

andreasbrett
Copy link

I really like your lightweight API to monitor smaller servers in Home Assistant. I just didn't like that all metrics were publicly available so I added some security features to harden the connection and make it private.

  • API can now be run via HTTPS
  • API can be configured to require authentication (digest authentication)
  • updated some requirements to latest version
  • changed JS code from older style "var" variable instantiation to "const/let" variable instantiation

Hope you like it and can pull this PR and push this to the Docker Hub.

@andreasbrett
Copy link
Author

andreasbrett commented Feb 27, 2021

I also created two tiny PRs for node-os-utils that would fix disk calculations and also provide "used memory percentage". If that gets pushed it would be cool if this new version was referenced in https://github.com/ned-kelly/ha-monitor-api/blob/master/src/package.json.

SunilWang/node-os-utils#17
SunilWang/node-os-utils#18

// EDIT
both PRs got merged and pushed to the npm repos => I updated package.json in this PR to use that new version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants