[pull] main from solidusio:main #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class will act as a stand-in for those classes that are currently configurable via Solidus' `AppConfiguration` class, but are only used from *within* the legacy promotion system. We have delegated these extension points to `Spree::Config.promotions`, so the `Spree::Core::NullPromotionConfiguration` needs to implement methods for them, but I don't see a lot of sense in providing Null implementations for things that aren't even needed.
We need to provide this accessor until people have either fully migrated to using the legacy promotions gem or the upcoming `solidus_promotions` gem. Those will supply their own configuration objects on which users can set a promotion code batch mailer class. This is only here to support deprecating `Spree::Config.promotion_code_batch_mailer_class` calls.
This configuration option is only called from within the legacy promotion system. Let's not create a `NullPromotionChooser`, but rather use the DeprecatedConfigurableClass that just warns without doing anything.
GitHub deprecated actions not using Node 20.
…motion-configuration Add missing methods to null promotion configuration
The previous implementation of `Spree::DeprecatedConfigurableClass` could deal with instance methods, but not with class methods. This creates a thing that issues deprecation warnings on instance methods and class methods.
This spec wants to test that all promotion codes are in the CSV, but it prescribes order, which is not guaranteed.
The `sort_link` helper only takes a single options hash since Ransack 3.0: activerecord-hackery/ransack#1289
When moving the legacy promotion system translations, I also moved the translation for `spree.match_choices`. These are also used on the backend products edit page, and need to stay in core.
Re-add translation for `match_choices`
Fix deprecation warning from Ransack
CI: Bump GH Actions versions
…oller-spec Fix flaky legacy promotion codes controller spec
…s-methods Deprecated Configurable Class: Allow class methods
The Github action "labeler" changed the format of the `labeler.yml` configuration file with labeler v5. I've used the format from the `Basic Examples` section, and hope this does what it did previously. See https://github.com/actions/labeler/blob/v5/README.md
Fix labeler configuration file for labeler@v5
…rget" This reverts commit 3149c0a.
Revert "Temporarily use labeler configuration from PR, not from PR ta…
Without checking out, the labeler seems to not work anymore.
Add Checkout to triage workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )