[pull] master from solidusio:master #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
We deprecated `#redirect_back_or_default` method in #4533 [1]. However, the original plan was halted because of auth problems in solidus_auth_devise. See solidusio/solidus_auth_devise/232 [2] for details. [1] - #4533 [2] - solidusio/solidus_auth_devise#232
Right now, passing a string or any other thing that is not
a Hash to the searcher in the `:search` parameter will raise
a NoMethodError.
For example: `/products?per_page=&keywords=&search=blub` would raise
a NoMethodError.
This commit avoids that a generic NoMethodError is raised and instead
raise a very specific error that serves two purposes:
1. Helps debugging: the error message contains the name of the param
that is invalid, making it easier to spot eventual issues.
2. Allows to rescue the error safely at the storefront level. For
example, to respond with a 400, one can easily do:
rescue_from Spree::Core::Search::Base::InvalidOptions do |error|
raise ActionController::BadRequest.new, error.message
end
…ion_of_redirect_back_or_default Revert the deprecation of `#redirect_back_or_default` method
Raise a custom extension passing invalid search params
This commit changes the CI matrix a little bit: The main tests are performed against Rails 7 vs Ruby 3.1 and 3.2. Testing Ruby 3.1 has been added to the Rails 6.1 matrix in order to guarantee at least one overlapping Ruby version between Rails version. This way there's a safe path to upgrade from Rails 6.1/Ruby 2.7 up to the latest Rails 7.0/Ruy 3.2.
Test Solidus against Ruby 3.2
The previous implementation was missing these fields, which might be useless for some implementations but there's no reason no to pass them along.
Having a default of `[]` seems more appropriate than `nil`. This will also allow stores to concatenate onto the default value and get automatic future additions in Solidus, whereas before, stores would have to define the array in their decorator if the core model did not set any values. This also applies to the deprecated whitelisted_ransackable_* as it delegates to allowed_ransackable_*.
Provide transaction_id and source in try_void
…-attribute-class-methods-usage Improve Ransackable attribute class methods usage
A useful scope. Usage: - Only return available products: `available: true`; and - Return non-available and available products: `available: false`.
…-to-product-ransackable_scopes Add available to Product.ransackable_scopes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )