Merge pull request solidusio#2280 from jhawthorn/leaky_database

Remove after_rollback from LogEntry
nebulab · Oct 20, 2017 · 88f531a · 88f531a
2 parents 7bde63d + 4aaeb35
commit 88f531a
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 12 deletions.
diff --git a/backend/spec/features/admin/orders/log_entries_spec.rb b/backend/spec/features/admin/orders/log_entries_spec.rb
@@ -14,7 +14,6 @@
  )
 
  payment.log_entries.create(
- source: payment.source,
  details: response.to_yaml
  )
  end

diff --git a/core/app/models/spree/log_entry.rb b/core/app/models/spree/log_entry.rb
@@ -2,17 +2,6 @@ module Spree
  class LogEntry < Spree::Base
  belongs_to :source, polymorphic: true
 
- # Fix for https://github.com/spree/spree/issues/1767
- # If a payment fails, we want to make sure we keep the record of it failing
- after_rollback :save_anyway, if: proc { !Rails.env.test? }
-
- def save_anyway
- log = Spree::LogEntry.new
- log.source = source
- log.details = details
- log.save!
- end
-
  def parsed_details
  @details ||= YAML.load(details)
  end