Skip to content

Commit

Permalink
Remove FAIL_FAST environment variable
Browse files Browse the repository at this point in the history
fail_fast can be set just by specifying rspec --fail-fast. Previously,
our use of the FAIL_FAST was preventing that from working, though.

I've removed this from the README because it
a) isn't important - nobody needs this to get started developing
b) is described in rspec's docs along with other options
  • Loading branch information
jhawthorn committed Dec 13, 2017
1 parent baf6e6f commit 140091a
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 10 deletions.
2 changes: 0 additions & 2 deletions api/spec/spec_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,6 @@

config.extend WithModel

config.fail_fast = ENV['FAIL_FAST'] || false

config.before(:each) do
Rails.cache.clear
reset_spree_preferences
Expand Down
2 changes: 0 additions & 2 deletions backend/spec/spec_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,6 @@

config.extend WithModel

config.fail_fast = ENV['FAIL_FAST'] || false

config.example_status_persistence_file_path = "./spec/examples.txt"

config.order = :random
Expand Down
2 changes: 0 additions & 2 deletions core/spec/spec_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@
config.include Spree::TestingSupport::Preferences
config.extend WithModel

config.fail_fast = ENV['FAIL_FAST'] || false

config.filter_run focus: true
config.run_all_when_everything_filtered = true

Expand Down
2 changes: 0 additions & 2 deletions frontend/spec/spec_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,6 @@
config.include Spree::TestingSupport::ControllerRequests, type: :controller
config.include Spree::TestingSupport::Flash

config.fail_fast = ENV['FAIL_FAST'] || false

config.example_status_persistence_file_path = "./spec/examples.txt"

config.order = :random
Expand Down
2 changes: 0 additions & 2 deletions sample/spec/spec_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@
# instead of true.
config.use_transactional_fixtures = false

config.fail_fast = ENV['FAIL_FAST'] || false

config.example_status_persistence_file_path = "./spec/examples.txt"

config.order = :random
Expand Down

0 comments on commit 140091a

Please sign in to comment.