Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for MacOS local setup #454

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Add docs for MacOS local setup #454

merged 2 commits into from
Aug 2, 2024

Conversation

aktech
Copy link
Member

@aktech aktech commented May 8, 2024

Reference Issues or PRs

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

Copy link

netlify bot commented May 8, 2024

Deploy Preview for nebari-docs ready!

Name Link
🔨 Latest commit 16fa986
🔍 Latest deploy log https://app.netlify.com/sites/nebari-docs/deploys/663bca9dc855d100082dcb68
😎 Deploy Preview https://deploy-preview-454--nebari-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@viniciusdc
Copy link
Contributor

I would preferable wait to merge this untill we ship all the images needed

@viniciusdc viniciusdc added the status: blocked ⛔️ This item is on hold due to another task label May 14, 2024
Copy link
Member

@marcelovilla marcelovilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this @aktech! 🚀

We can merge after nebari-dev/nebari-docker-images#141 has been merged.

@marcelovilla marcelovilla removed the status: blocked ⛔️ This item is on hold due to another task label Aug 2, 2024
@marcelovilla
Copy link
Member

@aktech and @viniciusdc I think we can already merge this as all other relevant PRs have been merged now.

@aktech
Copy link
Member Author

aktech commented Aug 2, 2024

Makes sense, thanks @marcelovilla

@aktech aktech merged commit 2656ab7 into main Aug 2, 2024
6 checks passed
@aktech aktech deleted the mac-m1-local-deploy-docs branch August 2, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

3 participants