urgent fix: correct issue with locations import #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dodumosu it appears that there are a few more places (mostly in the migrations) where |
|
it's not affecting Alembic. I just created a new database and ran the full set of migrations on it to check.
|
takinbo
pushed a commit
to dodumosu/apollo
that referenced
this pull request
Sep 9, 2024
takinbo
added a commit
that referenced
this pull request
Sep 9, 2024
* feat: implement exponents in QA * feat: add filter for submission values * chore: remove duplicated property * feat: implement value search and hotlinking this branch replaces the work on #948 * feat: use expression builder for value search * feat: use tom-select for first field dropdown * feat: use custom dropdown on value * chore: remove comment * chore: switch to selectize from tom-select * chore: remove tom-select artifacts * chore: don't use label in dropdown * fix: destroy selectize control when source changes to value * chore: add destroyed hook * feat: after changing source, warn for incomplete term * feat: clean up selectize when term is removed. * chore: various UI changes - remove icon on button - change button text color * fix: don't destroy all the dropdowns * fix: destroy all selectize instances on expression deletion * feat: start using new template * feat: working with new template * chore: change delete button visibility rule this commit changes the delete term button display rule. now, it displays on each term unless there's only one available * chore: remove unused code * fix: correct issue with locations import (#979) * chore(deps): bump gettext.js from 0.8.0 to 2.0.3 in /apollo/static (#978) Bumps gettext.js from 0.8.0 to 2.0.3. --- updated-dependencies: - dependency-name: gettext.js dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: fix PWA issues (#980) this commit fixes issues reported from users. the issues are due to upgrading marshmallow * chore(deps-dev): bump webpack from 5.76.0 to 5.94.0 in /apollo/static (#982) Bumps [webpack](https://github.com/webpack/webpack) from 5.76.0 to 5.94.0. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.76.0...v5.94.0) --- updated-dependencies: - dependency-name: webpack dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: replace all usage of _joined_entities() (#981) * fix: replace all usage of _joined_entities() SQLAlchemy 1.4 removed an internal query method (_joined_entities()) that was used to check if a query was already joined to a model. This pull request replaces the usages of that method. * fix: add missing file * feat: add unit tests and comment * fixed a few nits --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tim Akinbo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading to SQLAlchemy 1.4 seems to have uncovered an issue in Flask-SQLAlchemy that affected locations import relevant issue.
Please consider critical.