Allow using the plugin with babel-loader on node_modules #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CreateReactApp typically has babel-loader to process all the dependencies from node_modules to ensure that don't have things like `let` or `const` and other unexpected es6+ features. That config does not currently work the the plugin. The plugin tries to `require.resolve` resource string containing loader request path, eg `babel-loader?core-js/somefile.js`. Let's use userRequest instead of request when available to solve this problem.
ndelangen
approved these changes
Jul 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CreateReactApp typically has babel-loader to process all the dependencies from node_modules to ensure that don't have things like
letorconstand other unexpected es6+ features.That config does not currently work the the plugin. The plugin tries to
require.resolveresource string containing loader request path, egbabel-loader?core-js/somefile.js.Let's use userRequest instead of request when available to solve this problem.