Restore default SIGPIPE handler after fork() #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MQTT mosquitto library ignores SIGPIPE on purpose to "prevent unnecessary client quits in threaded mode": * https://github.com/eclipse/mosquitto/blob/d5970ca9985f4d3193fe7a359707723090bb13e9/lib/mosquitto.c#L112-L114 * https://github.com/eclipse/mosquitto/blob/d5970ca9985f4d3193fe7a359707723090bb13e9/src/mosquitto.c#L413 However, the default handler should be available to child processes spawned by mqtt-exec. Hence, we reset it after fork(). Otherwise, this causes issues when running test suites in Alpine. See https://gitlab.alpinelinux.org/alpine/aports/-/issues/13573
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MQTT mosquitto library ignores SIGPIPE on purpose to "prevent
unnecessary client quits in threaded mode":
However, the default handler should be available to child processes
spawned by mqtt-exec. Hence, we reset it after fork(). Otherwise, this
causes issues when running test suites in Alpine.
See https://gitlab.alpinelinux.org/alpine/aports/-/issues/13573