Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub workflow config run only for relevant branches #45

Merged

Conversation

Cakem1x
Copy link
Member

@Cakem1x Cakem1x commented Jan 24, 2024

This PR

  • removes CI for melodic (it's EOL)
  • restricts CI for noetic to only run on relevant branches. Currently, the CI also tries to run for our ROS2 humble branches, which always fails.\

With this PR, we won't get annoying emails from failed Github workflows while working on the ROS2 humble migration. Also, it will save some compute.

Not in this PR: ROS2 humble CI. It's not trivial to enable CI for ROS2 humble at the moment, because we cannot get mesh_navigation's dependencies via rosdep, as some of them are not yet available via apt. We'd need to get all of mesh_tools, mbf, lvr2, etc.

@Cakem1x Cakem1x self-assigned this Jan 24, 2024
@Cakem1x Cakem1x marked this pull request as ready for review January 24, 2024 11:31
@Cakem1x Cakem1x merged commit 483786d into master Jan 25, 2024
1 check passed
@Cakem1x Cakem1x deleted the update-github-workflow-config-run-only-for-relevant-branches branch January 25, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants