fix: header casing issues

.gitignore

@@ -3,3 +3,4 @@ composer.lock
 vendor
 downloads
 .idea/*
+tests/.phpunit.result.cache

README.md

@@ -67,6 +67,10 @@ Httpful highly encourages sending in pull requests. When submitting a pull requ
 
 # Changelog
 
+## 0.3.1
+
+ - FIX [PR #286](https://github.com/nategood/httpful/pull/286) Fixed header case sensitivity
+
 ## 0.3.0
 
  - REFACTOR Dropped support for dead versions of PHP. Updated the PHPUnit tests.

src/Httpful/Response/Headers.php

@@ -46,7 +46,7 @@ public static function fromString($string)
  */
  public function offsetExists($offset)
  {
- return isset($this->headers[$offset]);
+ return $this->getCaseInsensitive($offset) !== null;
  }
 
  /**
@@ -55,9 +55,7 @@ public function offsetExists($offset)
  */
  public function offsetGet($offset)
  {
- if (isset($this->headers[$offset])) {
- return $this->headers[$offset];
- }
+ return $this->getCaseInsensitive($offset);
  }
 
  /**
@@ -95,4 +93,14 @@ public function toArray()
  return $this->headers;
  }
 
+ private function getCaseInsensitive(string $key)
+ {
+ foreach ($this->headers as $header => $value) {
+ if (strtolower($key) === strtolower($header)) {
+ return $value;
+ }
+ }
+
+ return null;
+ }
 }

tests/Httpful/HttpfulTest.php

@@ -32,6 +32,15 @@ class HttpfulTest extends \PHPUnit\Framework\TestCase
 Content-Type: application/json
 Connection: keep-alive
 Transfer-Encoding: chunked\r\n";
+ const SAMPLE_JSON_HEADER_LOWERCASE =
+ "HTTP/2 200 
+date: Tue, 07 Jan 2020 09:11:21 GMT
+content-type: application/json
+content-length: 513
+access-control-allow-origin: *
+access-control-allow-methods: GET, POST, PUT, PATCH, DELETE
+access-control-allow-headers: Authorization, Content-Type, Accept-Encoding, Cache-Control, DNT
+cache-control: private, must-revalidate\r\n";
  const SAMPLE_JSON_RESPONSE = '{"key":"value","object":{"key":"value"},"array":[1,2,3,4]}';
  const SAMPLE_CSV_HEADER =
 "HTTP/1.1 200 OK
@@ -268,6 +277,17 @@ function testJsonResponseParse()
  $this->assertEquals(1, $response->body->array[0]);
  }
 
+ function testJsonResponseParseLowercaseHeaders()
+ {
+ $req = Request::init();
+ $response = new Response(self::SAMPLE_JSON_RESPONSE, self::SAMPLE_JSON_HEADER_LOWERCASE, $req);
+
+ $this->assertEquals("value", $response->body->key);
+ $this->assertEquals("value", $response->body->object->key);
+ $this->assertIsArray( $response->body->array);
+ $this->assertEquals(1, $response->body->array[0]);
+ }
+
  function testXMLResponseParse()
  {
  $req = Request::init()->sendsAndExpects(Mime::XML);