Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration Candidate 2020-07-29 #53

Merged
merged 8 commits into from
Aug 5, 2020
Merged

Integration Candidate 2020-07-29 #53

merged 8 commits into from
Aug 5, 2020

Conversation

astrogeco
Copy link
Contributor

@astrogeco astrogeco commented Aug 5, 2020

Describe the contribution
Fix #47
Fix #50
Close #49

Testing performed
Bundle CI - https://github.com/nasa/cFS/pull/119/checks

Expected behavior changes
PR #48 - Corrects return value of TO_LAB_init() to be int32 not int.

PR #51 - Fixes bug where an unset address values caused subscriptions to MsgId 0 over 200 times. Added a TO_UNUSED entry at the end of the subscription list and a break in the subscription loop when TO_UNUSED found. No more subscriptions on the unused table slots (no MsgId 0 subscriptions).

PR #52 - Add build number and baseline

System(s) tested on
Ubuntu

Additional context
Part of nasa/cFS#119

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman, NASA-GSFC
Gerardo E. Cruz-Ortiz, NASA-GSFC
Christopher D. Knight, NASA-ARC

Gerardo E. Cruz-Ortiz and others added 2 commits August 5, 2020 10:01
Reset version numbers to last release. Added build number and baseline
macros.
Added and using version string instead of number macros in reporting.
Close #49, Add build number and baseline to version file
@astrogeco astrogeco force-pushed the integration-candidate branch 3 times, most recently from 01b4686 to e94a3e4 Compare August 5, 2020 21:29
Set "development build" part of version string to ALL CAPS for readability
@astrogeco astrogeco marked this pull request as ready for review August 5, 2020 21:31
@astrogeco astrogeco merged commit d4a78ba into main Aug 5, 2020
@skliper skliper added this to the 2.4.0 milestone Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants