Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data instantiated in to_lab_sub_table.h is a standards violation #32

Closed
skliper opened this issue Apr 10, 2020 · 0 comments · Fixed by #46
Closed

Data instantiated in to_lab_sub_table.h is a standards violation #32

skliper opened this issue Apr 10, 2020 · 0 comments · Fixed by #46
Assignees
@CDKnightNASA
Labels
bug Something isn't working
Milestone
Bootes

Comments

@skliper
Copy link
Contributor

skliper commented Apr 10, 2020

Is your feature request related to a problem? Please describe.
Headers define, c code instantiates per coding standard

Describe the solution you'd like
Move and change to a c file. Also confuses "table" concept, since this isn't a real table. Maybe make it one?

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added the enhancement New feature or request label Apr 10, 2020
@skliper skliper mentioned this issue Apr 10, 2020
Merged
@jphickey jphickey mentioned this issue Jun 2, 2020
Closed
@CDKnightNASA CDKnightNASA self-assigned this Jun 2, 2020
CDKnightNASA added a commit to CDKnightNASA/to_lab that referenced this issue Jun 5, 2020
@CDKnightNASA
fix nasa#32 - make the TO table a proper table
5b536fc
astrogeco added a commit that referenced this issue Jun 16, 2020
@astrogeco
Merge pull request #45 from CDKnightNASA/fix-32-proper_table
7cbc526 
Fix #32, Make the TO table a proper table
@astrogeco astrogeco mentioned this issue Jun 17, 2020
Merged
@astrogeco astrogeco added this to the 2.4.0 milestone Oct 1, 2020
@astrogeco astrogeco added bug Something isn't working and removed enhancement New feature or request labels Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CDKnightNASA CDKnightNASA

Labels
bug Something isn't working
Projects
None yet
Milestone
Bootes
Development

Successfully merging a pull request may close this issue.

Integration Candidate: 2020-06-10 nasa/to_lab
3 participants
@CDKnightNASA @skliper @astrogeco