Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No notification of failure of CFE_EVS_Register() in TO_LAB_init() #147

Closed
thnkslprpt opened this issue Apr 5, 2023 · 0 comments · Fixed by #148
Closed

No notification of failure of CFE_EVS_Register() in TO_LAB_init() #147

thnkslprpt opened this issue Apr 5, 2023 · 0 comments · Fixed by #148

Comments

@thnkslprpt
Copy link
Contributor

thnkslprpt commented Apr 5, 2023

Describe the bug
to_lab currently has no notification of a failure of CFE_EVS_Register() in TO_LAB_init()

Code snips

to_lab/fsw/src/to_lab_app.c

Lines 146 to 156 in 7ca124c

/*
** Register with EVS
*/
CFE_EVS_Register(NULL, 0, CFE_EVS_EventFilter_BINARY);
/*
** Initialize housekeeping packet (clear user data area)...
*/
CFE_MSG_Init(CFE_MSG_PTR(TO_LAB_Global.HkTlm.TelemetryHeader), CFE_SB_ValueToMsgId(TO_LAB_HK_TLM_MID),
sizeof(TO_LAB_Global.HkTlm));
status = CFE_TBL_Register(&TO_SubTblHandle, "TO_LAB_Subs", sizeof(*TO_LAB_Subs), CFE_TBL_OPT_DEFAULT, NULL);

Expected behavior
Add CFE_ES_WriteToSysLog() to inform the user of failure to register with EVS.

Reporter Info
Avi Weiss @thnkslprpt

dzbaker added a commit that referenced this issue Nov 13, 2023
…ister-failure-during-init

Fix #147, Add check for failure of CFE_EVS_Register() during initialization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant