Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #15, Apply standard style #23

Merged
merged 2 commits into from
May 28, 2020
Merged

Fix #15, Apply standard style #23

merged 2 commits into from
May 28, 2020

Conversation

skliper
Copy link
Contributor

@skliper skliper commented May 21, 2020 •
edited
Loading

Describe the contribution
Whitespace changes only.
Fix #15

Testing performed
CI - https://travis-ci.com/github/skliper/cFS/builds/167637651

Expected behavior changes
None

System(s) tested on

  • Hardware: CI
  • OS: Ubuntu 18.04
  • Versions: Bundle w/ all whitespace change commits

Additional context
Note - not enforcing, just a single cleanup since there's no pending activity in this repo.

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added this to the 1.2.0 milestone May 21, 2020
@skliper skliper added CCB:FastTrack enhancement New feature or request labels May 21, 2020
jphickey
jphickey previously requested changes May 21, 2020
View reviewed changes
Copy link
Contributor

@jphickey jphickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this is combining some short functions all into one line, which (IMO) is neither readable nor desirable. Can we tweak the settings so it doesn't do this?

ut-stubs/sample_lib_stubs.c Outdated Show resolved Hide resolved
unit-test/coveragetest/coveragetest_sample_lib.c Outdated Show resolved Hide resolved
@skliper
Copy link
Contributor Author

skliper commented May 21, 2020

See AllowShortFunctionsOnASingleLine on https://clang.llvm.org/docs/ClangFormatStyleOptions.html, feel free to modify nasa/cFS/.clang-format and reapply

@skliper skliper mentioned this pull request May 23, 2020
Closed
@astrogeco astrogeco changed the base branch from master to integration-candidate May 26, 2020 22:54
@astrogeco astrogeco dismissed jphickey’s stale review May 28, 2020 14:18

Resolved in clang-format in the cfs repo. See nasa/cFS#88

@astrogeco astrogeco merged commit 553cf72 into nasa:integration-candidate May 28, 2020
@astrogeco astrogeco mentioned this pull request May 29, 2020
Merged
@skliper skliper deleted the fix15-apply-style branch February 1, 2021 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jphickey jphickey jphickey left review comments

Assignees
No one assigned
Labels
CCB:FastTrack enhancement New feature or request
Projects
None yet
Milestone
Bootes
Development

Successfully merging this pull request may close these issues.

Apply standard code style
3 participants
@skliper @jphickey @astrogeco