Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename files, functions, and variables to match LIBNAME_* pattern #33

Closed
jphickey opened this issue Oct 27, 2020 · 0 comments · Fixed by #34 or #35
Closed

Rename files, functions, and variables to match LIBNAME_* pattern #33

jphickey opened this issue Oct 27, 2020 · 0 comments · Fixed by #34 or #35
Assignees
@jphickey
Labels
breaking bug Something isn't working
Milestone
Caelum

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Naming convention in SAMPLE_LIB is not entirely consistent - some names start with SAMPLE_Lib, others just SAMPLE_.

Describe the solution you'd like
All variables, functions, and other identifiers should use a SAMPLE_LIB_ prefix.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
See nasa/sample_app#77. When fixing that, noted some issues in here too.

Requester Info
Joseph Hickey, Vantage Systems, Inc.
jphickey added a commit to jphickey/sample_lib that referenced this issue Oct 27, 2020
@jphickey
Fix nasa#33, Standardize to SAMPLE_LIB_ namespace prefix
4863b99 
Replace inconsistent SAMPLE_ And SAMPLE_Lib prefixes,
now all identifiers should start with SAMPLE_LIB_.
@jphickey jphickey mentioned this issue Oct 27, 2020
Merged
@jphickey jphickey self-assigned this Oct 27, 2020
@astrogeco astrogeco added this to the 1.3.0 milestone Nov 2, 2020
astrogeco added a commit that referenced this issue Nov 2, 2020
@astrogeco
Merge pull request #34 from jphickey/fix-33-name-consistency
9f4fb66 
Fix #33, Standardize to SAMPLE_LIB_ namespace prefix
@astrogeco astrogeco added breaking enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Nov 2, 2020
@astrogeco astrogeco mentioned this issue Nov 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
breaking bug Something isn't working
Projects
None yet
Milestone
Caelum
2 participants
@jphickey @astrogeco