sample_app Integration candidate: Equuleus-rc1+dev8 #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -107,10 +107,10 @@ | |||
| /* Initialization */ | |||
| /* */ | |||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * **/ | |||
| int32 SAMPLE_APP_Init(void) | |||
| CFE_Status_t SAMPLE_APP_Init(void) | |||
Check notice
Code scanning / CodeQL-coding-standard
Function too long Note
| @@ -107,10 +107,10 @@ | |||
| /* Initialization */ | |||
| /* */ | |||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * **/ | |||
| int32 SAMPLE_APP_Init(void) | |||
| CFE_Status_t SAMPLE_APP_Init(void) | |||
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
int32CFE status variables toCFE_Status_t#218. Addresses Issue Remaining int32 CFE status variables should be converted toCFE_Status_t#217Testing performed
cFS Bundle Checks
PSP Checks
Expected behavior changes
See PRs
System(s) tested on
Ubuntu 22.04
Additional context
Add any other context about the contribution here.
Third party code
If included, identify any third party code and provide text file of license
Contributor Info - All information REQUIRED for consideration of pull request
@thnkslprpt