Improve consistency in application of CFE_SB_MsgIdToValue/ValueToMsgId conversions #153
Assignees
Labels
enhancement
New feature or request
Comments
jphickey
added a commit
to jphickey/sample_app
that referenced
this issue
Sep 13, 2021
Whenever an integer value is used as a CFE_SB_MsgId_t, it should go through the explicit conversion using the supplied inline function.
astrogeco
added a commit
that referenced
this issue
Sep 21, 2021
Fix #153, apply CFE_SB_ValueToMsgId where required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
A
CFE_SB_MsgId_tvalue, like other IDs, is supposed to be a unique type/opaque value that identifies a message within the SB application context. Although it is currently implemented using an integer (uint32specifically) application should not assume this. Instead, a set of macros and inline conversion functions (CFE_SB_MsgIdToValue and CFE_SB_ValueToMsgId) are provided for when the application needs to interpret the value as an integer for a valid purpose.Describe the solution you'd like
Add conversions where they are currently missing
Additional context
See nasa/cFE#1945 for full info. A separate issue+PR will be submitted for each framework app.
Requester Info
Joseph Hickey, Vantage Systems, Inc.
The text was updated successfully, but these errors were encountered: