Fix #303, check that module type is not invalid #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jphickey
added
the
CCB:Ready
Rather than only calling "Init" on a "SIMPLE" module type, just check that it is not invalid instead. Even extension types still have an Init routine that needs to be called.
jphickey
force-pushed
the
fix-303-moduletype-check
branch
from
c0d7cae
to
82f5339
Compare
|
@excaliburtb @tngo67 - could you review and let me know if this would this impact your distribution? |
|
This doesn't appear to be a problem for us. |
skliper
approved these changes
Sep 7, 2021
astrogeco
removed
the
CCB:Ready
|
CCB:2021-09-08 APPROVED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Rather than only calling "Init" on a "SIMPLE" module type, just check that it is not invalid instead. Even extension types
still have an Init routine that needs to be called.
Fixes #303
Testing performed
Build and sanity check CFE, including using some HW access extension modules
Expected behavior changes
Module gets initialized as it should
System(s) tested on
Ubuntu
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.